Repository navigation
update test - #968
Merged
Merged
update test#968
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are present, and the test assertion now tolerates SVG attribute ordering while retaining checks for class and accessibility attributes.
No open issues 🎉
What changed in this PR
Updates the Octicons integration test to match the rendered SVG markup regardless of attribute ordering.
Changes:
- Replaces the exact SVG height string assertion with an attribute-aware regular expression.
- Preserves assertions for the SVG class and accessibility attributes.
| File | Description |
|---|---|
spec/github-pages/integration_spec.rb |
Adjusts the Octicons SVG height assertion to reliably match the rendered markup. |
Review effort: Lite (auto)
parkr
approved these changes
Nov 3, 2026
YiMysty
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The test in our integration file is failing due to a mismatch in assertions and what is being rendered.
Fix
Update the assertion to now match the rendered attribute.